Skip to content

Don't test -Cdefault-linker-libraries=yes when cross compiling. #95975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

Don't test -Cdefault-linker-libraries=yes when cross compiling. #95975

merged 1 commit into from
Apr 12, 2022
+1 −0

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 12, 2022 •
edited
Loading

See #95727 (comment) and the five comments below that.

Unblocks #95727.

@m-ou-se m-ou-se added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Apr 12, 2022
@rust-highfive
Copy link
Contributor

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 12, 2022
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 12, 2022

📌 Commit 284255a has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 12, 2022
@m-ou-se m-ou-se mentioned this pull request Apr 12, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 12, 2022
@bors
Auto merge of rust-lang#95987 - m-ou-se:rollup-sdevd9b, r=m-ou-se
52ca603 
Rollup of 4 pull requests

Successful merges:

 - rust-lang#95783 (rustdoc doctest: include signal number in exit status)
 - rust-lang#95794 (`parse_tt`: a few more tweaks)
 - rust-lang#95963 ([bootstrap] Grab the right FileCheck binary for dist when cross-compiling.)
 - rust-lang#95975 (Don't test -Cdefault-linker-libraries=yes when cross compiling.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 550a510 into rust-lang:master Apr 12, 2022
@rustbot rustbot added this to the 1.62.0 milestone Apr 12, 2022
@m-ou-se m-ou-se deleted the test-70093-no-cross branch April 13, 2022 09:01
@m-ou-se m-ou-se mentioned this pull request Apr 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@m-ou-se @rust-highfive @joshtriplett @bors @Mark-Simulacrum @rustbot